-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-40605][CONNECT][TESTS] Change to use log4j2.properties to configure test log output
#38041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala
Show resolved
Hide resolved
| appender.file.layout.type = PatternLayout | ||
| appender.file.layout.pattern = %d{yy/MM/dd HH:mm:ss.SSS} %t %p %c{1}: %m%n%ex | ||
|
|
||
| # Tests that launch java subprocesses can set the "test.appender" system property to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy from core module, the content after line 28 can also be deleted if it is not needed at present
|
friendly ping @HyukjinKwon @grundprinzip |
|
I'm not sure whether this should belong to the subtask of SPARK-39375. If not, please help move it |
|
Yeah, let's keep it under SPARK-39375 |
log4j2.properties to configure test log output log4j2.properties to configure test log output
log4j2.properties to configure test log output log4j2.properties to configure test log output
|
Merged to master |
|
I might have missed something: I didn't see a Is this a transitive dependency from |
|
@amaliujia Yes, you are right: |
|
thank @HyukjinKwon @wangyum |
What changes were proposed in this pull request?
This pr make
connectmodule change to use to uselog4j2.propertiesto configure test log output as others modules.Why are the changes needed?
You should use
log4j2.propertiesto configure logsDoes this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions