[SPARK-42438][SQL] Improve constraint propagation using multiTransform #38035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-toth
changed the title
peter-toth
force-pushed
the
SPARK-improve-constraint-generation
branch
from
a7452e5 to
b334a74
Compare
peter-toth
force-pushed
the
SPARK-improve-constraint-generation
branch
from
b334a74 to
d614f80
Compare
peter-toth
force-pushed
the
SPARK-improve-constraint-generation
branch
from
d614f80 to
0059d49
Compare
peter-toth
changed the title
peter-toth
force-pushed
the
SPARK-improve-constraint-generation
branch
from
0059d49 to
1024af5
Compare
peter-toth
changed the title
peter-toth
force-pushed
the
SPARK-improve-constraint-generation
branch
from
1024af5 to
713c63d
Compare
Contributor
Author
|
cc @cloud-fan |
peter-toth
commented
Feb 14, 2023
Contributor
Author
There was a problem hiding this comment.
I wanted to keep the current beahaviour in this PR.
peter-toth
changed the title
peter-toth
force-pushed
the
SPARK-improve-constraint-generation
branch
from
713c63d to
ed2c5ec
Compare
peter-toth
force-pushed
the
SPARK-improve-constraint-generation
branch
from
ed2c5ec to
8d5bd57
Compare
Contributor
Author
|
@cloud-fan, this PR refactors constraint propagation using |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR refectors constaint propagation using
TreeNode.multiTransform():LogicalPlan.getAllValidConstraints()because constraint pruning (based on the node output set) happens during the projection ingetAllValidConstraints().spark.sql.constraintPropagation.projectionLimitandspark.sql.constraintPropagation.inferenceLimitconfigs to limit the number of constraints generated. These limits can be useful in some usecases where otherwise constraint propagation needs to be disabled entirelly (spark.sql.constraintPropagation.enabled=false) due to huge number of constraints.Why are the changes needed?
Improvement.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing and new UTs.