Skip to content

[SPARK-40435][SQL][SS][TESTS][FOLLOWUP] Correct test precondition of PythonUDFSuite and ContinuousSuite #38028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 3 commits into from
Closed

[SPARK-40435][SQL][SS][TESTS][FOLLOWUP] Correct test precondition of PythonUDFSuite and ContinuousSuite #38028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bdd869
fix
LuciferYang Sep 28, 2022
1ef1dae
revert
LuciferYang Sep 28, 2022
7ad0e3d
Merge branch 'apache:master' into SPARK-40435-FOLLOWUP
LuciferYang Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/execution/python/PythonUDFSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class PythonUDFSuite extends QueryTest with SharedSparkSession {
}

test("SPARK-39962: Global aggregation of Pandas UDF should respect the column order") {
assume(shouldTestPythonUDFs)
assume(shouldTestPandasUDFs)
val df = Seq[(java.lang.Integer, java.lang.Integer)]((1, null)).toDF("a", "b")

val pandasTestUDF = TestGroupedAggPandasUDF(name = "pandas_udf")
Expand Down
2 changes: 1 addition & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/ContinuousSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ class ContinuousSuite extends ContinuousSuiteBase {
Seq(TestScalaUDF("udf"), TestPythonUDF("udf"), TestScalarPandasUDF("udf")).foreach { udf =>
test(s"continuous mode with various UDFs - ${udf.prettyName}") {
assume(
shouldTestPythonUDFs && udf.isInstanceOf[TestScalarPandasUDF] ||
shouldTestPandasUDFs && udf.isInstanceOf[TestScalarPandasUDF] ||
shouldTestPythonUDFs && udf.isInstanceOf[TestPythonUDF] ||
udf.isInstanceOf[TestScalaUDF])

Expand Down