[SPARK-40587][CONNECT] Support SELECT * in an explicit way in connect proto #38023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaliujia
changed the title
amaliujia
commented
Sep 27, 2022
|
|
||
| // represent * (e.g. SELECT *) | ||
| message UnresolvedStar { | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We need to expand this message later to support full fields of the star:
case class UnresolvedStar(target: Option[Seq[String]]) extends Star with Unevaluable {
which will be used to support Struct.
Contributor
Author
There was a problem hiding this comment.
one example is structDf.groupBy($"a").agg(min(struct($"record.*"))).sort("a").first()
Contributor
Author
cloud-fan
reviewed
Sep 28, 2022
connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Sep 28, 2022
grundprinzip
approved these changes
Sep 28, 2022
Contributor
grundprinzip
left a comment
grundprinzip
left a comment
There was a problem hiding this comment.
just a nit on comment.
|
Can one of the admins verify this patch? |
Contributor
Author
|
@cloud-fan friendly ping |
Contributor
|
thanks, merging to master! |
cloud-fan
pushed a commit
that referenced
this pull request
Oct 19, 2022
…ect * ### What changes were proposed in this pull request? 1. Sync newest proto to python client. 2. Update Aggregate to match proto change. 3. Change `select` to have it accept both `column` and `str` 4. Make sure `*` pass through the entire path which has been implemented on the server side #38023 ### Why are the changes needed? Update python client side to match the change in connect proto. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes #38218 from amaliujia/select_start_in_python. Authored-by: Rui Wang <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…ect * ### What changes were proposed in this pull request? 1. Sync newest proto to python client. 2. Update Aggregate to match proto change. 3. Change `select` to have it accept both `column` and `str` 4. Make sure `*` pass through the entire path which has been implemented on the server side apache#38023 ### Why are the changes needed? Update python client side to match the change in connect proto. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38218 from amaliujia/select_start_in_python. Authored-by: Rui Wang <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support
SELECT *in an explicit way by connect proto.Why are the changes needed?
Current proto uses empty project list for
SELECT *. However, this is an implicit way that it is hard to differentiatenot setandset but empty(the latter is invalid plan). For longer term proto compatibility, we should always use explicit fields for passing through information.Does this PR introduce any user-facing change?
No
How was this patch tested?
UT