[SPARK-40540][SQL] Migrate compilation errors onto error classes #37973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
Member
Author
|
@cloud-fan @itholic @srielau @anchovYu @gatorsmile Could you review this PR, please. |
amaliujia
reviewed
Sep 23, 2022
| "<msg>." | ||
| ] | ||
| }, | ||
| "_LEGACY_ERROR_TEMP_1000" : { |
Contributor
There was a problem hiding this comment.
just wondering why we choose use numbers than a descriptive way for the names?
E.g. _LEGACY_ERROR_TEMP_1000 => _LEGACY_ERROR_TEMP_LEGACY_STORE_ASSIGNMENT_POLICY_DISALLOWED?
Contributor
There was a problem hiding this comment.
Maybe it will cause too much work for the migration. If this does not bring much values please feel free to ignore.
Member
Author
There was a problem hiding this comment.
just wondering why we choose use numbers ...
@amaliujia Please, see in PR's description:
Why are the changes needed?
The migration on temporary error classes allows to gather statistics about errors and detect most popular error classes.
Contributor
There was a problem hiding this comment.
Thanks for the context! I see it better now.
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
Show resolved
Hide resolved
cloud-fan
approved these changes
Sep 26, 2022
Member
Author
|
Merging to master. Thank you, @cloud-fan for review. |
HyukjinKwon
added a commit
that referenced
this pull request
Sep 29, 2022
…ffer for 'Struct Star Expansion' test ### What changes were proposed in this pull request? This PR is a minor followup of #37973 to match the pattern of either `ArrayBuffer` (Scala 2.12) or `List` (Scala 2.13) in "Struct Star Expansion" test case at `SQLQuerySuite.scala`. ### Why are the changes needed? Currently, the test fails with Scala 2.13 (https://github.com/apache/spark/actions/runs/3146198025/jobs/5114388079): ``` [info] - Struct Star Expansion *** FAILED *** (1 second, 801 milliseconds) [info] Map("attributes" -> "List(a)") did not equal Map("attributes" -> "ArrayBuffer(a)") (SparkFunSuite.scala:328) [info] Analysis: [info] JavaCollectionWrappers$JMapWrapper(attributes: List(a) -> ArrayBuffer(a)) [info] org.scalatest.exceptions.TestFailedException: [info] at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472) [info] at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471) [info] at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231) [info] at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295) [info] at org.apache.spark.SparkFunSuite.checkError(SparkFunSuite.scala:328) [info] at org.apache.spark.SparkFunSuite.checkError(SparkFunSuite.scala:369) ``` We should also consider Scala 2.13 case. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually tested: ```scala scala> "List(a)".matches("(ArrayBuffer|List)\\(a\\)") res0: Boolean = true scala> "ArrayBuffer(a)".matches("(ArrayBuffer|List)\\(a\\)") res1: Boolean = true ``` Closes #38045 from HyukjinKwon/SPARK-40540-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to migrate 100 compilation errors onto temporary error classes with the prefix
_LEGACY_ERROR_TEMP_10xx. The error message will not include the error classes, so, in this way we will preserve the existing behaviour.Why are the changes needed?
The migration on temporary error classes allows to gather statistics about errors and detect most popular error classes. After that we could prioritise the work on migration.
The new error class name prefix
_LEGACY_ERROR_TEMP_proposed here kind of marks the error as developer-facing, not user-facing. Developers can still get the error class programmatically via theSparkThrowableinterface, so that they can build error infra with it. End users won't see the error class in the message. This allows us to do the error migration very quickly, and we can refine the error classes and mark them as user-facing later (naming them properly, adding tests, etc.).Does this PR introduce any user-facing change?
No. The error messages should be almost the same by default.
How was this patch tested?
By running the modified test suites: