[SPARK-4966][YARN]The MemoryOverhead value is setted not correctly #3797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
|
Can you provide some context / motivation for this change? If this fixes a bug, could you file a JIRA for it and link it to this PR? |
XuTingjun
changed the title
Contributor
Author
|
@JoshRosen I am sorry to forget describe this patch. I have created a jira for it, can you take a look? |
Contributor
|
I can take a look at this later this week. It would probably be a good idea for someone more familiar with the YARN code to take a look, too, since they might also be able to suggest how/whether tests could have prevented the underlying bug. |
Contributor
|
@XuTingjun yes, i agree with you. we should let parseArgs before using config amMemory and executorMemory. because parseArgs can change these value from args. |
Contributor
|
Looks good. +1. Thanks @XuTingjun |
asfgit
pushed a commit
that referenced
this pull request
Dec 29, 2014
Author: meiyoula <[email protected]> Closes #3797 from XuTingjun/MemoryOverhead and squashes the following commits: 5a780fc [meiyoula] Update ClientArguments.scala (cherry picked from commit 14fa87b) Signed-off-by: Thomas Graves <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.