[SPARK-40447][PS][FOLLOWUP] Fix doc of DataFrame.corr
#37927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @HyukjinKwon |
HyukjinKwon
approved these changes
Sep 19, 2022
Member
|
Merged to master. |
Contributor
Author
|
@HyukjinKwon Thank you! |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
Sep 20, 2022
### What changes were proposed in this pull request? Fix doc of `DataFrame.corr`, it should be the implementation of `Kendall` in PS has the complexity of O(#row * #row), since it apply a cross join (within each partition) to compute the statistics ### Why are the changes needed? Fix doc of `DataFrame.corr` ### Does this PR introduce _any_ user-facing change? yes, doc fixed ### How was this patch tested? manually check Closes apache#37927 from zhengruifeng/ps_df_kendall_doc. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix doc of
DataFrame.corr, it should be the implementation ofKendallin PS has the complexity of O(#row * #row), since it apply a cross join (within each partition) to compute the statisticsWhy are the changes needed?
Fix doc of
DataFrame.corrDoes this PR introduce any user-facing change?
yes, doc fixed
How was this patch tested?
manually check