Skip to content

[SPARK-38734][SQL] Remove the error class INDEX_OUT_OF_BOUNDS #37857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 2 commits into from
Closed

[SPARK-38734][SQL] Remove the error class INDEX_OUT_OF_BOUNDS #37857

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86a1b97
Remove the error class INDEX_OUT_OF_BOUNDS
MaxGekk Sep 12, 2022
af348bd
Fix ArrayDataIndexedSeqSuite
MaxGekk Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions core/src/main/resources/error/error-classes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,6 @@
}
}
},
"INDEX_OUT_OF_BOUNDS" : {
"message" : [
"Index <indexValue> must be between 0 and the length of the ArrayData."
],
"sqlState" : "22023"
},
"INTERNAL_ERROR" : {
"message" : [
"<message>"
Expand Down
16 changes: 0 additions & 16 deletions core/src/main/scala/org/apache/spark/SparkException.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,22 +316,6 @@ private[spark] class SparkIllegalArgumentException(
override def getQueryContext: Array[QueryContext] = context
}

/**
* Index out of bounds exception thrown from Spark with an error class.
*/
private[spark] class SparkIndexOutOfBoundsException(
errorClass: String,
errorSubClass: Option[String] = None,
messageParameters: Array[String])
extends IndexOutOfBoundsException(
SparkThrowableHelper.getMessage(errorClass, errorSubClass.orNull, messageParameters))
with SparkThrowable {

override def getMessageParameters: Array[String] = messageParameters
override def getErrorClass: String = errorClass
override def getErrorSubClass: String = errorSubClass.orNull
}

/**
* IO exception thrown from Spark with an error class.
*/
Expand Down
4 changes: 3 additions & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package org.apache.spark.sql.catalyst.util

import scala.reflect.ClassTag

import org.apache.spark.SparkException
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.expressions.{SpecializedGetters, UnsafeArrayData}
import org.apache.spark.sql.errors.QueryExecutionErrors
Expand Down Expand Up @@ -200,7 +201,8 @@ class ArrayDataIndexedSeq[T](arrayData: ArrayData, dataType: DataType) extends I
if (0 <= idx && idx < arrayData.numElements()) {
accessor(arrayData, idx).asInstanceOf[T]
} else {
throw QueryExecutionErrors.indexOutOfBoundsOfArrayDataError(idx)
throw SparkException.internalError(
s"Index $idx must be between 0 and the length of the ArrayData.")
}

override def length: Int = arrayData.numElements()
Expand Down
5 changes: 0 additions & 5 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1372,11 +1372,6 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase {
""".stripMargin.replaceAll("\n", " "))
}

def indexOutOfBoundsOfArrayDataError(idx: Int): Throwable = {
new SparkIndexOutOfBoundsException(
errorClass = "INDEX_OUT_OF_BOUNDS", None, Array(toSQLValue(idx, IntegerType)))
}

def malformedRecordsDetectedInRecordParsingError(e: BadRecordException): Throwable = {
new SparkException("Malformed records are detected in record parsing. " +
s"Parse Mode: ${FailFastMode.name}. To process malformed records as null " +
Expand Down