Skip to content

[SPARK-40339][SPARK-40342][SPARK-40345][SPARK-40348][PS] Implement quantile in Rolling/RollingGroupby/Expanding/ExpandingGroupby #37836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yikun wants to merge 3 commits into from
Closed

[SPARK-40339][SPARK-40342][SPARK-40345][SPARK-40348][PS] Implement quantile in Rolling/RollingGroupby/Expanding/ExpandingGroupby #37836

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83172a6
Implement quantile in Rolling/RollingGroupby/Expanding/ExpandingGroupby
Yikun Sep 8, 2022
e1dd816
Fix note lint
Yikun Sep 13, 2022
d39d5b5
Address comments
Yikun Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions python/pyspark/pandas/missing/window.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ class MissingPandasLikeExpanding:
corr = _unsupported_function_expanding("corr")
cov = _unsupported_function_expanding("cov")
median = _unsupported_function_expanding("median")
quantile = _unsupported_function_expanding("quantile")
validate = _unsupported_function_expanding("validate")

exclusions = _unsupported_property_expanding("exclusions")
Expand All @@ -101,7 +100,6 @@ class MissingPandasLikeRolling:
corr = _unsupported_function_rolling("corr")
cov = _unsupported_function_rolling("cov")
median = _unsupported_function_rolling("median")
quantile = _unsupported_function_rolling("quantile")
validate = _unsupported_function_rolling("validate")

exclusions = _unsupported_property_rolling("exclusions")
Expand All @@ -120,7 +118,6 @@ class MissingPandasLikeExpandingGroupby:
corr = _unsupported_function_expanding("corr")
cov = _unsupported_function_expanding("cov")
median = _unsupported_function_expanding("median")
quantile = _unsupported_function_expanding("quantile")
validate = _unsupported_function_expanding("validate")

exclusions = _unsupported_property_expanding("exclusions")
Expand All @@ -139,7 +136,6 @@ class MissingPandasLikeRollingGroupby:
corr = _unsupported_function_rolling("corr")
cov = _unsupported_function_rolling("cov")
median = _unsupported_function_rolling("median")
quantile = _unsupported_function_rolling("quantile")
validate = _unsupported_function_rolling("validate")

exclusions = _unsupported_property_rolling("exclusions")
Expand Down
8 changes: 8 additions & 0 deletions python/pyspark/pandas/tests/test_expanding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@ def test_expanding_max(self):
def test_expanding_mean(self):
self._test_expanding_func("mean")

def test_expanding_quantile(self):
self._test_expanding_func(lambda x: x.quantile(0.5), lambda x: x.quantile(0.5, "lower"))

def test_expanding_sum(self):
self._test_expanding_func("sum")

Expand Down Expand Up @@ -212,6 +215,11 @@ def test_groupby_expanding_max(self):
def test_groupby_expanding_mean(self):
self._test_groupby_expanding_func("mean")

def test_groupby_expanding_quantile(self):
self._test_groupby_expanding_func(
lambda x: x.quantile(0.5), lambda x: x.quantile(0.5, "lower")
)

def test_groupby_expanding_sum(self):
self._test_groupby_expanding_func("sum")

Expand Down
8 changes: 8 additions & 0 deletions python/pyspark/pandas/tests/test_rolling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ def test_rolling_max(self):
def test_rolling_mean(self):
self._test_rolling_func("mean")

def test_rolling_quantile(self):
self._test_rolling_func(lambda x: x.quantile(0.5), lambda x: x.quantile(0.5, "lower"))

def test_rolling_sum(self):
self._test_rolling_func("sum")

Expand Down Expand Up @@ -212,6 +215,11 @@ def test_groupby_rolling_max(self):
def test_groupby_rolling_mean(self):
self._test_groupby_rolling_func("mean")

def test_groupby_rolling_quantile(self):
self._test_groupby_rolling_func(
lambda x: x.quantile(0.5), lambda x: x.quantile(0.5, "lower")
)

def test_groupby_rolling_sum(self):
self._test_groupby_rolling_func("sum")

Expand Down
Loading