-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-40393][PS][TESTS] Refactor expanding and rolling test for function with input #37835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
itholic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
| if not pd_func: | ||
| pd_func = ps_func |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I got a bit confusion for this part.
Could you tell one example that considers this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's that it uses the same function if pd_func is omitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just like: self._test_groupby_rolling_func("count").
We add ps_func and pd_func separately for some case like: self._test_groupby_expanding_func(lambda x:x.quantile(0.5), lambda x: x.quantile(0.5, "lower")), pd_func and ps_func is different.
|
Merged to master. |
What changes were proposed in this pull request?
Refactor expanding and rolling test for function with input
Why are the changes needed?
Refactor expanding and rolling test for function with input:
Does this PR introduce any user-facing change?
No
How was this patch tested?