[SPARK-40366][INFRA] Add spark namespace to spark ci image
#37815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yikun
referenced
this pull request
Sep 7, 2022
### What changes were proposed in this pull request? Upgrade pandas to 1.4.4 in infra and doc gen ### Why are the changes needed? https://pandas.pydata.org/docs/whatsnew/v1.4.4.html Especially, fix bugs which mentioned in #36353: - Fixed regression in DataFrame.fillna() not working on a DataFrame with a MultiIndex (GH47649) - Fixed regression in DataFrame.eval() creating a copy when updating inplace (GH47449) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Closes #37810 from Yikun/pandas-1.4.4. Authored-by: Yikun Jiang <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Member
Author
|
Let's wait pyspark, spark, lint ci passed (about 1 hour) |
Member
Author
|
Related github incident: https://www.githubstatus.com/incidents/d181frs643d4 |
Member
Author
|
Looks like github resolved this issue:
we might don't need this workaround. @HyukjinKwon works in my local (without this PR): https://github.com/Yikun/spark/runs/8224647901?check_suite_focus=true |
Member
|
Thanks for letting me know! |
Member
Author
|
According others reply, same issue happened again on github side....let me rebase and see does this workaround still avaiable or not. |
Yikun
force-pushed
the
FIX-image-namespace
branch
from
746609e to
890b944
Compare
Member
Author
|
BTW, I also drafted a PR to reduce the potential impact in future. |
Contributor
|
This helped me fix the same issue. Here are the complete steps:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change the spark ci image from
"ghcr.io/$REPO_OWNER/spark/$IMG_NAME"to"ghcr.io/$REPO_OWNER/spark/$IMG_NAME".Due to some reasons (docker/build-push-action#687), original base ci image has permission issue, this is a bug of ghcr. Let's frist recover CI first (old image has permission issue but new image not), I will contact github team and take a deep look later.
Related Github incidents:
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
base image ci passed