[SPARK-40302][K8S][TESTS] Add YuniKornSuite
#37753
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
YuniKornSuite
Member
Author
|
Could you review this, @viirya ? |
viirya
approved these changes
Sep 1, 2022
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
Looks good. Just CI seems not working well?
Member
Author
|
Thank you, @viirya . Yes, there was irrelevant |
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 1, 2022
This PR aims the followings. 1. Add `YuniKornSuite` integration test suite which extends `KubernetesSuite` on Apache YuniKorn scheduler. 2. Support `--default-exclude-tags` command to override `test.default.exclude.tags`. To improve test coverage. No. This is a test suite addition. Since this requires `Apache YuniKorn` installation, the test suite is disabled by default. So, CI K8s integration test should pass without running this suite. In order to run the tests, we need to override `test.default.exclude.tags` like the following. **SBT** ``` $ build/sbt -Psparkr -Pkubernetes -Pkubernetes-integration-tests \ -Dspark.kubernetes.test.deployMode=docker-desktop "kubernetes-integration-tests/test" \ -Dtest.exclude.tags=minikube,local \ -Dtest.default.exclude.tags= ``` **MAVEN** ``` $ dev/dev-run-integration-tests.sh --deploy-mode docker-desktop \ --exclude-tag minikube,local \ --default-exclude-tags '' ``` Closes #37753 from dongjoon-hyun/SPARK-40302. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit b2e38e1) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
Merged to master/3.3. |
Contributor
|
Very nice, thank you @dongjoon-hyun ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims the followings.
YuniKornSuiteintegration test suite which extendsKubernetesSuiteon Apache YuniKorn scheduler.--default-exclude-tagscommand to overridetest.default.exclude.tags.Why are the changes needed?
To improve test coverage.
Does this PR introduce any user-facing change?
No. This is a test suite addition.
How was this patch tested?
Since this requires
Apache YuniKorninstallation, the test suite is disabled by default.So, CI K8s integration test should pass without running this suite.
In order to run the tests, we need to override
test.default.exclude.tagslike the following.SBT
MAVEN