Skip to content

[SPARK-40229][PS][TEST] Re-enable excel I/O test for pandas API on Spark #37671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itholic wants to merge 11 commits into from
Closed

[SPARK-40229][PS][TEST] Re-enable excel I/O test for pandas API on Spark #37671

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9b7f7dc
[SPARK-40229][PS][TEST] Re-enable excel I/O test for pandas API on Sp…
itholic Aug 26, 2022
d149f5d
Install package for Python 3.9
itholic Aug 26, 2022
922df50
Merge branch 'master' of https://github.com/apache/spark into SPARK-4…
itholic Aug 29, 2022
6f0edbb
Merge branch 'master' of https://github.com/apache/spark into SPARK-4…
itholic Aug 31, 2022
83d9f51
Disable the read_excel test
itholic Aug 31, 2022
5a2f0cb
Merge branch 'master' of https://github.com/apache/spark into SPARK-4…
itholic Sep 1, 2022
1e573a5
Merge branch 'master' of https://github.com/apache/spark into SPARK-4…
itholic Sep 5, 2022
af72f08
Added TODO
itholic Sep 5, 2022
cb2b955
Move install to Dockerfile
itholic Sep 6, 2022
2488c3c
Merge branch 'master' of https://github.com/apache/spark into SPARK-4…
itholic Sep 6, 2022
89b192d
Merge branch 'master' into SPARK-40229
itholic Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,10 @@ jobs:
uses: actions/setup-java@v1
with:
java-version: ${{ matrix.java }}
- name: Install Python packages (Python 3.9, PyPy3)
run: |
# To test excel I/O for pandas API on Spark.
python3.9 -m pip install openpyxl
Copy link
Member

@HyukjinKwon HyukjinKwon Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add this into Dockerfile? https://github.com/apache/spark/blob/master/dev/infra/Dockerfile

Copy link
Contributor Author

@itholic itholic Sep 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Just moved

- name: List Python packages (Python 3.9, PyPy3)
run: |
python3.9 -m pip list
Expand Down
1 change: 0 additions & 1 deletion python/pyspark/pandas/tests/test_dataframe_conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ def get_excel_dfs(pandas_on_spark_location, pandas_location):
"expected": pd.read_excel(pandas_location, index_col=0),
}

@unittest.skip("openpyxl")
def test_to_excel(self):
Copy link
Member

@Yikun Yikun Sep 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this case for pypy3? Will it affect developers run tests?

spark/python/run-tests.py

Line 202 in e83aedd

python_execs = [x for x in ["python3.9", "pypy3"] if which(x)]

(I remember we run pypy3 and python3.9 in CI....but not running, pls let me know if I missed something history changes...)

Copy link
Member

@HyukjinKwon HyukjinKwon Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually PyPy is not tested with Pandas API on Spark per https://github.com/apache/spark/blob/master/dev/sparktestsupport/modules.py#L663-L667 because pyarrow, etc are not available with PyPy. Should probably docunent it somewhere but let's do that separately.

Copy link
Member

@Yikun Yikun Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good to know!

with self.temp_dir() as dirpath:
pandas_location = dirpath + "/" + "output1.xlsx"
Expand Down
1 change: 1 addition & 0 deletions python/pyspark/pandas/tests/test_dataframe_spark_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ def test_spark_io(self):
expected_idx.sort_values(by="f").to_spark().toPandas(),
)

# TODO(SPARK-40353): re-enabling the `test_read_excel`.
@unittest.skip("openpyxl")
def test_read_excel(self):
with self.temp_dir() as tmp:
Expand Down