[SPARK-40004][CORE] Remove redundant LevelDB.get in RemoteBlockPushResolver
#37435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This minor change should not be coupled with the refactoring work of SPARK-38909, I think this change may worth doing even if SPARK-38909 is not accepted in the end. |
srowen
approved these changes
Aug 8, 2022
Contributor
|
Merged to master. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr just remove redundant
LevelDB.get(key)inRemoteBlockPushResolver.Why are the changes needed?
This is no need to check
db.get(key) != nullbeforedb.delete(key). LevelDB will handle this scene.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GitHub Actions