[SPARK-39977][BUILD] Remove unnecessary guava exclusion from jackson-module-scala #37405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
Author
|
cc @wangyum, could u please take a look at this minor issue? |
srowen
approved these changes
Oct 24, 2022
Member
|
Merged to master |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…module-scala ### What changes were proposed in this pull request? Remove unnecessary guava exclusion from jackson-module-scala ### Why are the changes needed? The exclusion added in SPARK-6149, the recent versions of jackson-module-scala does not depend on gauva any more, so we can remove this exclusion. https://mvnrepository.com/artifact/com.fasterxml.jackson.module/jackson-module-scala_2.12/2.13.3 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Exsiting UT. Closes apache#37405 from pan3793/SPARK-39977. Authored-by: Cheng Pan <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove unnecessary guava exclusion from jackson-module-scala
Why are the changes needed?
The exclusion added in SPARK-6149, the recent versions of jackson-module-scala does not depend on gauva any more, so we can remove this exclusion.
https://mvnrepository.com/artifact/com.fasterxml.jackson.module/jackson-module-scala_2.12/2.13.3
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exsiting UT.