[MINOR][SQL] Improve the comments about null tracking for UnsafeRow #37340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
what's wrong with "null bit set"? A bit set for null tracking. |
HyukjinKwon
reviewed
Jul 30, 2022
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Yeah I don't particularly find this confusing too
cloud-fan
reviewed
Aug 1, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
Outdated
Show resolved
Hide resolved
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
I'm also not sure if this is an improvement or not, but I feel new sentence looks like becoming repeating itself a little.
The null-tracking portion is used for null tracking
dongjoon-hyun
approved these changes
Aug 3, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Since it's not a big deal, let's merge this for @beliefer and move on to more important PRs. :)
cloud-fan
reviewed
Aug 4, 2022
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
Outdated
Show resolved
Hide resolved
beliefer
force-pushed
the
UnsafeRow_comment
branch
from
a7d94db to
d91c561
Compare
…ssions/UnsafeRow.java Co-authored-by: Wenchen Fan <[email protected]>
beliefer
force-pushed
the
UnsafeRow_comment
branch
from
e0500c2 to
65f30b2
Compare
…ssions/UnsafeRow.java Co-authored-by: Wenchen Fan <[email protected]>
Contributor
|
thank, merging to master! |
Contributor
Author
|
@cloud-fan @dongjoon-hyun @HyukjinKwon Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR expect to improve the comments about null tracking for
UnsafeRow.The old comment of
UnsafeRowhave confused text[null bit set].In fact, the portion is a lot of bit or bit array which does't always be null.
On the other hand, it tell users nothing. we need the information more clear.
Why are the changes needed?
Improve the comments about null tracking for
UnsafeRow.Does this PR introduce any user-facing change?
'No'.
Just update comments.
How was this patch tested?
N/A