Skip to content

Conversation

@c21
Copy link
Contributor

@c21 c21 commented Jul 14, 2022

What changes were proposed in this pull request?

We support Hive bucketing (with Hive hash function - https://issues.apache.org/jira/browse/SPARK-32709 and https://issues.apache.org/jira/browse/SPARK-32712) started from Spark 3.3.0, we should also update the documentation to reflect the fact, that we are no longer incompatible with Hive bucketing.

Why are the changes needed?

Update user-facing documentation to avoid confusion.

Does this PR introduce any user-facing change?

Yes, the doc itself.

How was this patch tested?

Manually checked the doc file locally.

@github-actions github-actions bot added the DOCS label Jul 14, 2022
@c21
Copy link
Contributor Author

c21 commented Jul 14, 2022

The removed documentation is on https://spark.apache.org/docs/latest/sql-migration-guide.html:
Screen Shot 2022-07-14 at 12 32 53 AM

@c21
Copy link
Contributor Author

c21 commented Jul 14, 2022

@cloud-fan - could you help take a look when you have time? Thanks.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it would be great to mention the relavant JIRAs in the PR description though.

@c21
Copy link
Contributor Author

c21 commented Jul 15, 2022

LGTM but it would be great to mention the relavant JIRAs in the PR description though.

@HyukjinKwon - sure, added.

@HyukjinKwon
Copy link
Member

Merged to master and branch-3.3.

HyukjinKwon pushed a commit that referenced this pull request Jul 15, 2022
### What changes were proposed in this pull request?

We support Hive bucketing (with Hive hash function - https://issues.apache.org/jira/browse/SPARK-32709 and https://issues.apache.org/jira/browse/SPARK-32712) started from Spark 3.3.0, we should also update the documentation to reflect the fact, that we are no longer incompatible with Hive bucketing.

### Why are the changes needed?

Update user-facing documentation to avoid confusion.

### Does this PR introduce _any_ user-facing change?

Yes, the doc itself.

### How was this patch tested?

Manually checked the doc file locally.

Closes #37189 from c21/doc.

Authored-by: Cheng Su <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit 528b9eb)
Signed-off-by: Hyukjin Kwon <[email protected]>
@c21 c21 deleted the doc branch July 15, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants