Skip to content

[SPARK-4870] Add spark version to driver log #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[SPARK-4870] Add spark version to driver log #3717

wants to merge 4 commits into from

Conversation

@liyezhang556520
Copy link
Contributor

@liyezhang556520 liyezhang556520 commented Dec 17, 2014

No description provided.

@SparkQA
Copy link

SparkQA commented Dec 17, 2014

Test build #24529 has started for PR 3717 at commit 96dc115.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 17, 2014

Test build #24529 has finished for PR 3717 at commit 96dc115.

  • This patch fails RAT tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 17, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24529/
Test FAILed.

@liyezhang556520
Copy link
Contributor Author

liyezhang556520 commented Dec 17, 2014

jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Dec 17, 2014

Test build #24530 has started for PR 3717 at commit 96dc115.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 17, 2014

Test build #24530 has finished for PR 3717 at commit 96dc115.

  • This patch fails RAT tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 17, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24530/
Test FAILed.

nchammas referenced this pull request Dec 17, 2014
[Release] Cache known author translations locally
b85044e 
This bypasses unnecessary calls to the Github and JIRA API.
Additionally, having a local cache allows us to remember names
that we had to manually discover ourselves.
@nchammas
Copy link
Contributor

nchammas commented Dec 17, 2014

Jenkins, retest this please.

@nchammas
Copy link
Contributor

nchammas commented Dec 17, 2014

The build was broken, but it's been fixed now.

@SparkQA
Copy link

SparkQA commented Dec 17, 2014

Test build #24536 has started for PR 3717 at commit 96dc115.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 17, 2014

Test build #24536 has finished for PR 3717 at commit 96dc115.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 17, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24536/
Test PASSed.

andrewor14
andrewor14 reviewed Dec 20, 2014
View reviewed changes
core/src/main/scala/org/apache/spark/SparkConf.scala Outdated
Copy link
Contributor

@andrewor14 andrewor14 Dec 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like the right place for this. I would put it in SparkContext itself

Copy link
Contributor Author

@liyezhang556520 liyezhang556520 Dec 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrewor14 , yes, it does seem like not the right place here, It's better to put it in SparkContext. But the code would be a little ugly if put the log there, see my next commit in this PR. Is there any better way?

@SparkQA
Copy link

SparkQA commented Dec 22, 2014

Test build #24692 has started for PR 3717 at commit 330f70c.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 22, 2014

Test build #24693 has started for PR 3717 at commit ccd30d7.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 22, 2014

Test build #24692 has finished for PR 3717 at commit 330f70c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 22, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24692/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Dec 22, 2014

Test build #24693 has finished for PR 3717 at commit ccd30d7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 22, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24693/
Test PASSed.

@andrewor14
Copy link
Contributor

andrewor14 commented Dec 22, 2014

This looks fine. I'm going to tweak the log format a little bit when I merge it into master. Thanks

@asfgit asfgit closed this in 39272c8 Dec 22, 2014
@liyezhang556520 liyezhang556520 deleted the version2Log branch December 24, 2014 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liyezhang556520 @SparkQA @AmplabJenkins @nchammas @andrewor14