-
Notifications
You must be signed in to change notification settings - Fork 29k
SPARK-4814 [CORE] Enable assertions in SBT, Maven tests / AssertionError from Hive's LazyBinaryInteger #3692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #24443 has started for PR 3692 at commit
|
|
Test build #24443 has finished for PR 3692 at commit
|
|
Test FAILed. |
|
Jenkins, retest this please. |
|
Test build #24468 has started for PR 3692 at commit
|
|
Test build #24468 has finished for PR 3692 at commit
|
|
Test PASSed. |
|
LGTM. Per @marmbrus's comment over on the JIRA, I don't think that the Hive assertion failures should necessarily block enabling this for the rest of Spark, so I'm going to merge this into |
…ror from Hive's LazyBinaryInteger This enables assertions for the Maven and SBT build, but overrides the Hive module to not enable assertions. Author: Sean Owen <[email protected]> Closes #3692 from srowen/SPARK-4814 and squashes the following commits: caca704 [Sean Owen] Disable assertions just for Hive f71e783 [Sean Owen] Enable assertions for SBT and Maven build (cherry picked from commit 81112e4) Signed-off-by: Josh Rosen <[email protected]>
…ror from Hive's LazyBinaryInteger This enables assertions for the Maven and SBT build, but overrides the Hive module to not enable assertions. Author: Sean Owen <[email protected]> Closes #3692 from srowen/SPARK-4814 and squashes the following commits: caca704 [Sean Owen] Disable assertions just for Hive f71e783 [Sean Owen] Enable assertions for SBT and Maven build (cherry picked from commit 81112e4) Signed-off-by: Josh Rosen <[email protected]> Conflicts: pom.xml
|
Alright, picked this into |
This enables assertions for the Maven and SBT build, but overrides the Hive module to not enable assertions.