Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Dec 14, 2014

This enables assertions for the Maven and SBT build, but overrides the Hive module to not enable assertions.

@SparkQA
Copy link

SparkQA commented Dec 14, 2014

Test build #24443 has started for PR 3692 at commit caca704.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 14, 2014

Test build #24443 has finished for PR 3692 at commit caca704.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24443/
Test FAILed.

@srowen
Copy link
Member Author

srowen commented Dec 15, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Dec 15, 2014

Test build #24468 has started for PR 3692 at commit caca704.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 15, 2014

Test build #24468 has finished for PR 3692 at commit caca704.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24468/
Test PASSed.

@JoshRosen
Copy link
Contributor

LGTM. Per @marmbrus's comment over on the JIRA, I don't think that the Hive assertion failures should necessarily block enabling this for the rest of Spark, so I'm going to merge this into master and all of the maintenance branches. Thanks for fixing this!

asfgit pushed a commit that referenced this pull request Dec 16, 2014
…ror from Hive's LazyBinaryInteger

This enables assertions for the Maven and SBT build, but overrides the Hive module to not enable assertions.

Author: Sean Owen <[email protected]>

Closes #3692 from srowen/SPARK-4814 and squashes the following commits:

caca704 [Sean Owen] Disable assertions just for Hive
f71e783 [Sean Owen] Enable assertions for SBT and Maven build

(cherry picked from commit 81112e4)
Signed-off-by: Josh Rosen <[email protected]>
@asfgit asfgit closed this in 81112e4 Dec 16, 2014
asfgit pushed a commit that referenced this pull request Dec 16, 2014
…ror from Hive's LazyBinaryInteger

This enables assertions for the Maven and SBT build, but overrides the Hive module to not enable assertions.

Author: Sean Owen <[email protected]>

Closes #3692 from srowen/SPARK-4814 and squashes the following commits:

caca704 [Sean Owen] Disable assertions just for Hive
f71e783 [Sean Owen] Enable assertions for SBT and Maven build

(cherry picked from commit 81112e4)
Signed-off-by: Josh Rosen <[email protected]>

Conflicts:
	pom.xml
@JoshRosen
Copy link
Contributor

Alright, picked this into master, branch-1.2, and branch-1.1. There's a nasty merge conflict when trying to pick this back into branch-1.0, so I'm going to not pick that for now and tag this for a possible backport in JIRA.

@srowen srowen deleted the SPARK-4814 branch December 29, 2014 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants