Skip to content

[SPARK-36979][SQL][TESTS][FOLLOWUP] Move the test from SQLQuerySuite to SQLQueryTestSuite #36910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wangyum wants to merge 1 commit into from
Closed

[SPARK-36979][SQL][TESTS][FOLLOWUP] Move the test from SQLQuerySuite to SQLQueryTestSuite #36910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sql/core/src/test/resources/sql-tests/inputs/non-excludable-rule.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,7 @@ WITH tmp AS (
SELECT id FROM range(4)
)
SELECT id FROM range(3) WHERE id > (SELECT max(id) FROM tmp);

-- SPARK-36979
SET spark.sql.optimizer.excludedRules=org.apache.spark.sql.catalyst.optimizer.RewriteLateralSubquery;
SELECT * FROM testData, LATERAL (SELECT * FROM testData) LIMIT 1;
16 changes: 16 additions & 0 deletions sql/core/src/test/resources/sql-tests/results/non-excludable-rule.sql.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,19 @@ SELECT id FROM range(3) WHERE id > (SELECT max(id) FROM tmp)
struct<id:bigint>
-- !query output
2


-- !query
SET spark.sql.optimizer.excludedRules=org.apache.spark.sql.catalyst.optimizer.RewriteLateralSubquery
-- !query schema
struct<key:string,value:string>
-- !query output
spark.sql.optimizer.excludedRules org.apache.spark.sql.catalyst.optimizer.RewriteLateralSubquery


-- !query
SELECT * FROM testData, LATERAL (SELECT * FROM testData) LIMIT 1
-- !query schema
struct<key:int,value:string,key:int,value:string>
-- !query output
1 1 1 1
7 changes: 0 additions & 7 deletions sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4225,13 +4225,6 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
checkAnswer(sql("""SELECT from_json(R'{"a": "\\"}', 'a string')"""), Row(Row("\\")))
}

test("SPARK-36979: Add RewriteLateralSubquery rule into nonExcludableRules") {
withSQLConf(SQLConf.OPTIMIZER_EXCLUDED_RULES.key ->
"org.apache.spark.sql.catalyst.optimizer.RewriteLateralSubquery") {
sql("SELECT * FROM testData, LATERAL (SELECT * FROM testData)").collect()
}
}

test("TABLE SAMPLE") {
withTable("test") {
sql("CREATE TABLE test(c int) USING PARQUET")
Expand Down