Skip to content

[SPARK-39495][SQL][TESTS] Support SPARK_TEST_HIVE_CLIENT_VERSIONS for HiveClientVersions #36894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 2 commits into from
Closed

[SPARK-39495][SQL][TESTS] Support SPARK_TEST_HIVE_CLIENT_VERSIONS for HiveClientVersions #36894

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5890fe8
[SPARK-39495][SQL][TESTS] Support `SPARK_TEST_HIVE_CLIENT_VERSIONS` f…
dongjoon-hyun Jun 16, 2022
538c7ba
Avoid Java 11 'strip' method
dongjoon-hyun Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientVersions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ import scala.collection.immutable.IndexedSeq
import org.apache.commons.lang3.{JavaVersion, SystemUtils}

private[client] trait HiveClientVersions {
protected val versions = if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
private val testVersions = sys.env.get("SPARK_TEST_HIVE_CLIENT_VERSIONS")
protected val versions = if (testVersions.nonEmpty) {
testVersions.get.split(",").map(_.strip).filter(_.nonEmpty).toIndexedSeq
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I forgot that String.strip was added in Java 11.

} else if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
IndexedSeq("2.0", "2.1", "2.2", "2.3", "3.0", "3.1")
} else {
IndexedSeq("0.12", "0.13", "0.14", "1.0", "1.1", "1.2", "2.0", "2.1", "2.2", "2.3", "3.0",
Expand Down