[SPARK-39492][SQL] Rework MISSING_COLUMN #36891
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srielau
force-pushed
the
SPARK-39492-Rework-MISSING_COLUMN
branch
7 times, most recently
from
e51c49a to
4497bd3
Compare
srielau
force-pushed
the
SPARK-39492-Rework-MISSING_COLUMN
branch
from
4497bd3 to
a4b6957
Compare
|
Can one of the admins verify this patch? |
srielau
commented
Jun 17, 2022
srielau
force-pushed
the
SPARK-39492-Rework-MISSING_COLUMN
branch
3 times, most recently
from
1c4f625 to
667ab59
Compare
gengliangwang
approved these changes
Jun 17, 2022
Member
gengliangwang
left a comment
gengliangwang
left a comment
There was a problem hiding this comment.
The error message looks clear now!
Member
|
https://github.com/srielau/spark/runs/6942384510?check_suite_focus=true @srielau I guess you will have to retrigger the tests |
srielau
force-pushed
the
SPARK-39492-Rework-MISSING_COLUMN
branch
from
667ab59 to
9e7ca86
Compare
srielau
force-pushed
the
SPARK-39492-Rework-MISSING_COLUMN
branch
from
9e7ca86 to
66a48ea
Compare
Member
|
Merging to master |
gengliangwang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace the error class MISSING_COLUMN with UNRESOLVED_COLUMN wit the following new text:
A column or function parameter with name cannot be resolved. Did you mean one of the following? []
Why are the changes needed?
The existing class name and text does not reflect what is really happening. The column may well exist, it may just not be within scope.
Does this PR introduce any user-facing change?
Yes, we we replace an error class name.
How was this patch tested?
test all affected test suites with MISSING_COLUMN