[SPARK-39468][CORE][FOLLOWUP] Use lazy val for host
#36882
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
lazy val for host
HyukjinKwon
approved these changes
Jun 16, 2022
Member
|
Merged to master. |
Contributor
|
Thanks for fixing this @dongjoon-hyun ! |
Member
Author
|
Thank you @mridulm ! |
Member
Author
|
Oh, Thank you for approval and merging, @HyukjinKwon , too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
lazy val hostinstead ofval host.Why are the changes needed?
To address the review comments about
RpcAddressobject size.RpcAddressto add[]toIPv6if needed #36868 (comment)RpcAddressto add[]toIPv6if needed #36868 (comment)Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.