[SPARK-39488][SQL] Simplify the error handling of TempResolvedColumn #36809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
force-pushed
the
error
branch
2 times, most recently
from
fb4fe23 to
adc464f
Compare
cloud-fan
changed the title
cloud-fan
changed the title
Contributor
Author
viirya
reviewed
Jun 16, 2022
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
Show resolved
Hide resolved
viirya
reviewed
Jun 16, 2022
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
Outdated
Show resolved
Hide resolved
viirya
reviewed
Jun 16, 2022
Comment on lines
-53
to
-54
| val DATA_TYPE_MISMATCH_ERROR_MESSAGE = TreeNodeTag[String]("dataTypeMismatchError") | ||
|
|
Member
There was a problem hiding this comment.
just to make sure this isn't related to TempResolvedColumn, right?
Contributor
Author
There was a problem hiding this comment.
It was used to do error handling of TempResolvedColumn, but we don't need it now as the logic is simplified.
Contributor
There was a problem hiding this comment.
just to make sure this isn't related to
TempResolvedColumn, right?
Yes, I added this in #36746. It is not needed after this pr
viirya
approved these changes
Jun 16, 2022
…ysis/Analyzer.scala Co-authored-by: Liang-Chi Hsieh <[email protected]>
Contributor
Author
|
thanks for review, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #35404 and #36746 , to simplify the error handling of
TempResolvedColumn.The idea is:
ResolveAggregationFunctionsin the main resolution batch createsTempResolvedColumnand only removes it if the aggregate expression is fully resolved. It either stripsTempResolvedColumnif it's inside aggregate function or group expression, or restoresTempResolvedColumntoUnresolvedAttributeotherwise, hoping other rules can resolve it.RemoveTempResolvedColumnin a latter batch can still hitTempResolvedColumnif the aggregate expression is unresolved (due to input type mismatch for example, e.g.avg(bool_col),date_add(int_group_col, 1)). At this stage, there is no way to restoreTempResolvedColumntoUnresolvedAttributeand resolve it differently. The query will fail and we should blindly stripTempResolvedColumnto provide better error message.Why are the changes needed?
code cleanup
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests