[SPARK-39266][CORE] Cleanup unused spark.rpc.numRetries and spark.rpc.retry.wait configs
#36645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
May 24, 2022
HyukjinKwon
approved these changes
May 24, 2022
yaooqinn
approved these changes
May 24, 2022
Member
|
Merged to master. Thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR cleans up the
spark.rpc.numRetriesandspark.rpc.retry.waitconfigs, both of which are unused.Why are the changes needed?
Since SPARK-19450 / #16790 in Spark 2.2.0, both of these configurations are unused and setting them has no effect. Marking the configs as deprecated and cleaning them up from the docs helps to avoid user confusion.
In addition, this cleanup slightly improves the performance of constructing
RpcEndpointRefs because it removes two unused fields that were initialized by reading the deprecated configs.Does this PR introduce any user-facing change?
No.
How was this patch tested?
n/a