[SPARK-39162][SQL][3.3] Jdbc dialect should decide which function could be pushed down #36556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld be pushed down
cloud-fan
approved these changes
May 16, 2022
huaxingao
reviewed
May 16, 2022
| * @param funcName Upper-cased function name | ||
| * @return True if the database supports function. | ||
| */ | ||
| @Since("3.3.0") |
Contributor
There was a problem hiding this comment.
Let's hope this can still make RC2.
huaxingao
approved these changes
May 16, 2022
Contributor
|
thanks, merging to 3.3! |
cloud-fan
pushed a commit
that referenced
this pull request
May 18, 2022
…ld be pushed down ### What changes were proposed in this pull request? This PR used to back port #36521 to 3.3 ### Why are the changes needed? Let function push-down more flexible. ### Does this PR introduce _any_ user-facing change? 'No'. New feature. ### How was this patch tested? Exists tests. Closes #36556 from beliefer/SPARK-39162_3.3. Authored-by: Jiaan Geng <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Contributor
Author
|
@cloud-fan @huaxingao Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR used to back port #36521 to 3.3
Why are the changes needed?
Let function push-down more flexible.
Does this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
Exists tests.