[SPARK-38939][SQL][FOLLOWUP] Replace named parameter with comment in ReplaceColumns #36487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
cloud-fan
reviewed
May 9, 2022
Contributor
There was a problem hiding this comment.
Sorry I'm a bit confused. named parameter has been widely used in the Spark codebase, what's wrong with it?
Contributor
Author
There was a problem hiding this comment.
Yeah, named parameter is right. But there is a compilation error when k8s integration test. Please see PR description for more information. And you can exec this command to check it again
build/sbt -Pkubernetes -Pkubernetes-integration-tests -Dtest.exclude.tags=r "kubernetes-integration-tests/test"
Contributor
There was a problem hiding this comment.
Do you know why the issue only happens in this place?
Contributor
Author
There was a problem hiding this comment.
Because deleteColumn#TableChange is Java file. I replace named parameter with comment, because it's used in Apache Spark.
…changes#ReplaceColumns
dcoliversun
changed the title
cloud-fan
approved these changes
May 9, 2022
|
Can one of the admins verify this patch? |
huaxingao
approved these changes
May 9, 2022
jackierwzhang
approved these changes
May 9, 2022
huaxingao
pushed a commit
that referenced
this pull request
May 9, 2022
…ReplaceColumns ### What changes were proposed in this pull request? This PR aims to replace named parameter with comment in `ReplaceColumns`. ### Why are the changes needed? #36252 changed signature of deleteColumn#**TableChange.java**, but this PR breaks sbt compilation in k8s integration test. ```shell > build/sbt -Pkubernetes -Pkubernetes-integration-tests -Dtest.exclude.tags=r -Dspark.kubernetes.test.imageRepo=kubespark "kubernetes-integration-tests/test" [error] /Users/IdeaProjects/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2AlterTableCommands.scala:147:45: not found: value ifExists [error] TableChange.deleteColumn(Array(name), ifExists = false) [error] ^ [error] /Users/IdeaProjects/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2AlterTableCommands.scala:159:19: value ++ is not a member of Array[Nothing] [error] deleteChanges ++ addChanges [error] ^ [error] two errors found [error] (catalyst / Compile / compileIncremental) Compilation failed ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass the GA and k8s integration test. Closes #36487 from dcoliversun/SPARK-38939. Authored-by: Qian.Sun <[email protected]> Signed-off-by: huaxingao <[email protected]> (cherry picked from commit 16b5124) Signed-off-by: huaxingao <[email protected]>
Contributor
|
Thanks! Merged to master and 3.3. |
Contributor
Author
|
Thank you @cloud-fan @jackierwzhang @huaxingao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to replace named parameter with comment in
ReplaceColumns.Why are the changes needed?
#36252 changed signature of deleteColumn#TableChange.java, but this PR breaks sbt compilation in k8s integration test.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the GA and k8s integration test.