[SPARK-39049][PYTHON][CORE][ML] Remove unneeded pass
#36383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornjorgensen
changed the title
passpass
HyukjinKwon
approved these changes
Apr 28, 2022
Member
|
Merged to master and branch-3.3. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 28, 2022
### What changes were proposed in this pull request? Remove unneeded `pass` ### Why are the changes needed? Class`s Estimator, Transformer and Evaluator are abstract classes. Which has functions. ValueError in def run() has code. By removing `pass` it will be easier to read, understand and reuse code. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests passed. Closes #36383 from bjornjorgensen/remove-unneeded-pass. Lead-authored-by: Bjørn Jørgensen <[email protected]> Co-authored-by: bjornjorgensen <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 0e87587) Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove unneeded
passWhy are the changes needed?
Class`s Estimator, Transformer and Evaluator are abstract classes. Which has functions.
ValueError in def run() has code.
By removing
passit will be easier to read, understand and reuse code.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests passed.