[SPARK-38803][K8S][TESTS] Lower minio cpu to 250m (0.25) from 1 in K8s IT #36096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yikun
changed the title
spark.kubernetes.test.minioRequestCores
...ration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DepsTestsSuite.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
requested changes
Apr 7, 2022
Member
There was a problem hiding this comment.
BTW, do we need a parameter for this? This is not a Spark configuration. I guess we can have a simply small value until it works.
Member
Author
There was a problem hiding this comment.
Yep, I also considered this before. I think 0.25 (250m) could be a reasonable smaller value in here. Because I also see this experience value in link.
Will update soon.
Yikun
changed the title
spark.kubernetes.test.minioRequestCores
Member
Author
|
IT is still passed: https://github.com/Yikun/spark/actions/workflows/k8s_integration_test.yml since set minio cpu to |
dongjoon-hyun
changed the title
minio cpu to 250m (0.25) from 1 in K8s IT
dongjoon-hyun
approved these changes
Apr 8, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @Yikun .
Merged to master for Apache Spark 3.4.
dongjoon-hyun
changed the title
minio cpu to 250m (0.25) from 1 in K8s IT
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 20, 2022
…s IT ### What changes were proposed in this pull request? This PR aims to set minio request cpu to `250m` (0.25). - This value also recommand in [link](https://docs.gitlab.com/charts/charts/minio/#installation-command-line-options). - There are [no cpu request limitation](https://github.com/minio/minio/blob/a3e317773a2b90a433136e1ff2a8394bc5017c75/helm/minio/values.yaml#L251) on current minio. ### Why are the changes needed? In some cases (such as resource limited case), we reduce request cpu of minio. See also: #35830 (review) ### Does this PR introduce _any_ user-facing change? No, test only ### How was this patch tested? IT passsed Closes #36096 from Yikun/minioRequestCores. Authored-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 5ea2b38) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
This test commit is backported to branch-3.3 according to the community request, #36087 (comment) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to set minio request cpu to
250m(0.25).Why are the changes needed?
In some cases (such as resource limited case), we reduce request cpu of minio.
See also: #35830 (review)
Does this PR introduce any user-facing change?
No, test only
How was this patch tested?
IT passsed