Skip to content

[SPARK-38391][SPARK-38768][SQL][FOLLOWUP] Add comments for pushLimit and pushTopN of PushDownUtils #36092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beliefer wants to merge 3 commits into from
Closed

[SPARK-38391][SPARK-38768][SQL][FOLLOWUP] Add comments for pushLimit and pushTopN of PushDownUtils #36092

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a51d18
[SPARK-38391][SPARK-38768][SQL][FOLLOWUP] Add comments for pushLimit …
beliefer Apr 7, 2022
d368a1f
Update code
beliefer Apr 7, 2022
385759b
Update code
beliefer Apr 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,11 @@ object PushDownUtils extends PredicateHelper {
}

/**
* Pushes down LIMIT to the data source Scan
* Pushes down LIMIT to the data source Scan.
*
* @return the tuple of Boolean. The first Boolean value represents whether to push down, and
* the second Boolean value represents whether to push down partially which means to
* keep the `Limit`.

@huaxingao huaxingao Apr 9, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we be a little more clear and say something like
...the second Boolean value represents whether to push down partially, which means Spark will keep the Limit and do it again.

@beliefer beliefer Apr 10, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

*/
def pushLimit(scanBuilder: ScanBuilder, limit: Int): (Boolean, Boolean) = {
scanBuilder match {
Expand All @@ -127,7 +131,11 @@ object PushDownUtils extends PredicateHelper {
}

/**
* Pushes down top N to the data source Scan
* Pushes down top N to the data source Scan.
*
* @return the tuple of Boolean. The first Boolean value represents whether to push down, and
* the second Boolean value represents whether to push down partially which means to
* keep the `Sort` and `Limit`.

@huaxingao huaxingao Apr 9, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as the above

*/
def pushTopN(
scanBuilder: ScanBuilder,
Expand Down