Skip to content

Conversation

@monkeyboy123
Copy link
Contributor

@monkeyboy123 monkeyboy123 commented Apr 1, 2022

What changes were proposed in this pull request?

This pr use EquivalentExpressions getEquivalentExprs function instead of getExprState at SubexpressionEliminationSuite, and remove cpus paramter.

Why are the changes needed?

Fixes build error

Does this PR introduce any user-facing change?

NO

How was this patch tested?

CI Tests

…rs function instead of getExprState at SubexpressionEliminationSuite
@monkeyboy123
Copy link
Contributor Author

Can we merge it ?cc: @cloud-fan

@cloud-fan
Copy link
Contributor

thanks, merging to 3.2/3.1

cloud-fan pushed a commit that referenced this pull request Apr 1, 2022
…ntExprs function instead of getExprState at SubexpressionEliminationSuite

### What changes were proposed in this pull request?

This pr use EquivalentExpressions getEquivalentExprs function instead of getExprState at SubexpressionEliminationSuite, and remove cpus paramter.
### Why are the changes needed?

Fixes build error

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

CI Tests

Closes #36033 from monkeyboy123/SPARK-38754.

Authored-by: Dereck Li <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
cloud-fan pushed a commit that referenced this pull request Apr 1, 2022
…ntExprs function instead of getExprState at SubexpressionEliminationSuite

### What changes were proposed in this pull request?

This pr use EquivalentExpressions getEquivalentExprs function instead of getExprState at SubexpressionEliminationSuite, and remove cpus paramter.
### Why are the changes needed?

Fixes build error

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

CI Tests

Closes #36033 from monkeyboy123/SPARK-38754.

Authored-by: Dereck Li <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
(cherry picked from commit f677272)
Signed-off-by: Wenchen Fan <[email protected]>
@cloud-fan cloud-fan closed this Apr 1, 2022
@dongjoon-hyun
Copy link
Member

Hi, @cloud-fan .

This seems to break branch-3.2 compilation.

[error] /home/runner/work/spark/spark/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala:404:26: value getEquivalentExprs is not a member of org.apache.spark.sql.catalyst.expressions.EquivalentExpressions
[error]       assert(equivalence.getEquivalentExprs(expression).size == 0)
[error]                          ^
[error] one error found

@dongjoon-hyun
Copy link
Member

Originally, branch-3.1 was broken, but branch-3.2 wasn't.
Given that, the forward-port from 3.1 to 3.2 looks wrong to me.
I'm going to revert this from branch-3.2 and recover branch-3.2 compilation.
If we need this in branch-3.2 for some other reasons, please make a follow-up PR to get a build result.
Thanks!

kazuyukitanimura pushed a commit to kazuyukitanimura/spark that referenced this pull request Aug 10, 2022
…ntExprs function instead of getExprState at SubexpressionEliminationSuite

### What changes were proposed in this pull request?

This pr use EquivalentExpressions getEquivalentExprs function instead of getExprState at SubexpressionEliminationSuite, and remove cpus paramter.
### Why are the changes needed?

Fixes build error

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

CI Tests

Closes apache#36033 from monkeyboy123/SPARK-38754.

Authored-by: Dereck Li <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
(cherry picked from commit f677272)
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants