[SPARK-4733] Add missing prameter comments in ShuffleDependency #3594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
There was a problem hiding this comment.
Actually I think this is both the map side and the reduce side. Maybe just say the aggregator to use for aggregation?
Member
Author
There was a problem hiding this comment.
Yes, I thnks so. I'll also fix it.
maropu
force-pushed
the
DependencyJavadocFix
branch
from
dcdb8f3 to
a3496a5
Compare
maropu
force-pushed
the
DependencyJavadocFix
branch
from
a3496a5 to
32129b4
Compare
Member
Author
|
Fixed. |
Contributor
|
Ok merging this into master thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing Javadoc comments in ShuffleDependency.