-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-38621][K8S][BUILD][INFRA] Add volcano module to release-build.sh #35922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We added volcano module before, and will introduced spark k8s with volcano support in 3.3. @dongjoon-hyun @HyukjinKwon @holdenk I'm not very familar with release process, but I think we need this PR to make sure volcano module can be published in final release bin/tar? |
|
Any comments? |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Apache Spark 3.3, -1 from my side. And, even for master branch, since some release managers still uses master branch release script, I believe we need to hold on this until Apache Spark 3.3.0 is released.
If you don't mind, let's talk later for Apache Spark 3.4 after 3.3.0 release.
|
To reviewers. It was intentional not to expose this module into the Apache Spark release artifacts. While I've been helping this SPIP, there were many issues in Volcano library and volcano module until the last day of branch cut. I'm also not sure about the stability yet. This module and configurations are re-designed to isolate each custom scheduler from the others. This is still in an experiment stage and I believe we need more time in this area. AFAIK, we couldn't add |
To be clear, most of these problems because volcano branch selection, recently, we are also continuously verifying the work of volcano and spark, it's stable now.
Yes, for sure, we specifically say this in the documentation. For users who want use this experimental feature, what's the best practice? Sounds like we need to mention build release with
In fact, I have been getting in touch with @yangwwei and working together to make |
|
No, there was no available release version, wasn't it. Apache Spark 3.3.0 consumes a set of specific released versions, not branch, @Yikun
For Yunikorn, thanks. I believe they can follow our latest architecture easily if they start. |
|
I know that Volcano also has a long dev history. That's the reason why I was surprised during supporting you. We don't know what we are going to hit more in the future until we try. I'm expecting that Apache Spark 3.3.0 will give us more broader and world-wide feedback and help us. What we need is a safe step to introduce a new feature.
|
@dongjoon-hyun Totally, agree. then I need to added the some doc like To be a double confirmed, this doc PR can be backport to 3.3 after getting merged, right? To make sure users can know how to use this experimental features in 3.3. |
|
Yep, that's right. And, it's up to the author and the committer of that PR. You can ping her. |
|
BTW, your previous doc PR is also not in |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
What changes were proposed in this pull request?
Add volcano module into release-build.sh
Why are the changes needed?
Add volcano module into release-build.sh
Does this PR introduce any user-facing change?
No
How was this patch tested?
ci passed