[SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support #35885
Conversation
…n values" This reverts commit e21cb62.
|
@HyukjinKwon This is the PR created from scratch, but still GAs are not triggered. |
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @MaxGekk . Pending CI.
I'm also not sure about the reason why the CI is not triggered here.
|
cc @dtenedor and @gengliangwang , too |
|
Actually having this in 3.3 can return a better error message if users are running queries with column default. |
|
We agreed on reverting already, @gengliangwang . :) |
|
@gengliangwang FYI, GAs haven't been triggered yet. |
|
@dongjoon-hyun Yes |
|
It's passed at https://github.com/MaxGekk/spark/runs/5581819136?check_suite_focus=true so we can merge it anyway |
|
Will make a fix soon. |
|
Merging to branch-3.3. Thank you, @gengliangwang @dongjoon-hyun and @HyukjinKwon for review. |
…support ### What changes were proposed in this pull request? Revert the commit e21cb62 from `branch-3.3`. ### Why are the changes needed? See discussion in the PR #35690. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By existing test suites. Closes #35885 from MaxGekk/revert-default-column-support-3.3. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
4 participants
What changes were proposed in this pull request?
Revert the commit e21cb62 from
branch-3.3.Why are the changes needed?
See discussion in the PR #35690.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By existing test suites.