Skip to content

[SPARK-38579][SQL][WEBUI]Requesting Restful API can cause NullPointerException #35884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yimin-yang wants to merge 5 commits into from
Closed

[SPARK-38579][SQL][WEBUI]Requesting Restful API can cause NullPointerException #35884

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76f2a2e
fixed npe
yimin-yang Mar 17, 2022
eb2475d
update
yimin-yang Mar 21, 2022
15ee2e7
Merge branch 'apache:master' into fix-npe
yimin-yang Mar 22, 2022
4a82e03
update
yimin-yang Mar 22, 2022
73cdf03
update
yimin-yang Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion sql/core/src/main/scala/org/apache/spark/status/api/v1/sql/SqlResource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import java.util.Date
import javax.ws.rs._
import javax.ws.rs.core.MediaType

import scala.collection.immutable.HashMap
import scala.util.{Failure, Success, Try}

import org.apache.spark.JobExecutionStatus
Expand Down Expand Up @@ -94,7 +95,15 @@ private[v1] class SqlResource extends BaseAppResource {

val duration = exec.completionTime.getOrElse(new Date()).getTime - exec.submissionTime
val planDetails = if (planDescription) exec.physicalPlanDescription else ""
val nodes = if (details) printableMetrics(graph.allNodes, exec.metricValues) else Seq.empty
Comment thread
yimin-yang marked this conversation as resolved.
val nodes = if (details) {
if (exec.metricValues != null) {
printableMetrics(graph.allNodes, exec.metricValues)
} else {
printableMetrics(graph.allNodes, new HashMap[Long, String])
}

@mridulm mridulm Mar 18, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option(exec.metricValues).getOrElse(Map()) instead

} else {
Seq.empty
}
val edges = if (details) graph.edges else Seq.empty

new ExecutionData(
Expand Down