Skip to content

Conversation

@LuciferYang
Copy link
Contributor

What changes were proposed in this pull request?

This pr aims to upgrade log4j2 to 2.17.2.

Why are the changes needed?

This version brings a lot of fixes released to log1.x support, the release notes and change report as follows:

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GA

@github-actions github-actions bot added the BUILD label Mar 14, 2022
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @LuciferYang and all!
Merged to master for Apache Spark 3.3.

@LuciferYang
Copy link
Contributor Author

thanks all

@Yikun
Copy link
Member

Yikun commented Mar 15, 2022

image
FYI, the K8S IT break since this commit:

  • Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j2.properties *** FAILED *** (3 minutes, 14 seconds)

https://github.com/Yikun/spark/runs/5543930959?check_suite_focus=true

@LuciferYang
Copy link
Contributor Author

@dongjoon-hyun @yaooqinn should revert this first? I haven't found the cause of the failure yet

@wangyum
Copy link
Member

wangyum commented Mar 15, 2022

Reverted through 2a63fea

@LuciferYang
Copy link
Contributor Author

thanks @wangyum

@dongjoon-hyun
Copy link
Member

Thank you for reverting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants