Skip to content

[SPARK-36058][K8S][TESTS][FOLLOWUP] Fix error message to include exception correctly #35829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[SPARK-36058][K8S][TESTS][FOLLOWUP] Fix error message to include exception correctly #35829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...on-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import com.google.common.base.Charsets
import com.google.common.io.Files
import io.fabric8.kubernetes.api.model.Pod
import io.fabric8.kubernetes.client.{Watcher, WatcherException}
import io.fabric8.kubernetes.client.KubernetesClientException
import io.fabric8.kubernetes.client.Watcher.Action
import org.scalatest.{BeforeAndAfter, BeforeAndAfterAll, Tag}
import org.scalatest.concurrent.{Eventually, PatienceConfiguration}
Expand Down Expand Up @@ -106,11 +107,10 @@ class KubernetesSuite extends SparkFunSuite
.withName(execPod.getMetadata.getName)
.getLog
} catch {
case e: io.fabric8.kubernetes.client.KubernetesClientException =>
"Error fetching log (pod is likely not ready) ${e}"
case e: KubernetesClientException =>
s"Error fetching log (pod is likely not ready) $e"
}
logInfo(s"\nBEGIN executor (${execPod.getMetadata.getName}) POD log:\n" +
podLog)
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Mar 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this because the indentation is wrong.

logInfo(s"\nBEGIN executor (${execPod.getMetadata.getName}) POD log:\n$podLog")
logInfo(s"END executor (${execPod.getMetadata.getName}) POD log")
}
}
Expand Down