[SPARK-38436][PYTHON][TESTS] Fix test_ceil to test ceil
#35755
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
huaxingao
approved these changes
Mar 7, 2022
Contributor
|
cc @HyukjinKwon |
dongjoon-hyun
changed the title
test_ceil to test ceil
dongjoon-hyun
approved these changes
Mar 7, 2022
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @bjornjorgensen and @huaxingao .
Merged to master/3.2.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 7, 2022
### What changes were proposed in this pull request? We have two functions that are testing the same thing. ### Why are the changes needed? To test both floor and ceil. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Got the green light. Closes #35755 from bjornjorgensen/Test-ceil. Authored-by: Bjørn Jørgensen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 6c486d2) Signed-off-by: Dongjoon Hyun <[email protected]>
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
### What changes were proposed in this pull request? We have two functions that are testing the same thing. ### Why are the changes needed? To test both floor and ceil. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Got the green light. Closes apache#35755 from bjornjorgensen/Test-ceil. Authored-by: Bjørn Jørgensen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 6c486d2) Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 1951e6a) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We have two functions that are testing the same thing.
Why are the changes needed?
To test both floor and ceil.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Got the green light.