[SPARK-38416][PYTHON][TESTS] Change day to month #35741
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
srowen
approved these changes
Mar 6, 2022
Member
|
[SPARK-38416][PYTHON][TESTS] Change day to month PR title need to be changed as above, otherwise LGTM. |
HyukjinKwon
changed the title
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Mar 6, 2022
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 7, 2022
### What changes were proposed in this pull request? Right now we have two functions that are testing the same thing. ### Why are the changes needed? To test both day and mount ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Got the green light. Closes #35741 from bjornjorgensen/change-day-to-month. Authored-by: bjornjorgensen <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit b651617) Signed-off-by: Hyukjin Kwon <[email protected]>
Member
|
Merged to master and branch-3.2. |
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
### What changes were proposed in this pull request? Right now we have two functions that are testing the same thing. ### Why are the changes needed? To test both day and mount ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Got the green light. Closes apache#35741 from bjornjorgensen/change-day-to-month. Authored-by: bjornjorgensen <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit b651617) Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 1406d0c) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Right now we have two functions that are testing the same thing.
Why are the changes needed?
To test both day and mount
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Got the green light.