[SPARK-38276][SQL] Add approved TPCDS plans under ANSI mode#35598
Closed
gengliangwang wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-38276][SQL] Add approved TPCDS plans under ANSI mode#35598gengliangwang wants to merge 1 commit intoapache:masterfrom
gengliangwang wants to merge 1 commit intoapache:masterfrom
Conversation
cloud-fan
approved these changes
Feb 21, 2022
cloud-fan
approved these changes
Feb 21, 2022
cloud-fan
approved these changes
Feb 21, 2022
Member
Author
|
Merging to master |
Member
|
Also, cc @huaxingao , @sunchao and @viirya , too |
Member
|
This looks good. One question, this only adds q83, if we make any change that causes difference between non-ansi and ansi plans in other queries, can we automatically detect it? |
Member
Author
Yes, we will set up a new GA test job with ANSI on. In the beginning, the job will be executed after commits are merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
q83 has a different plan output under ANSI mode. Because of the ANSI type coercion, it can actually push down a
INpredicate into Parquet data source. The following screenshot contains all the differences between default plan(left) and ansi plan(right):This PR is to add approved TPCDS plans under ANSI mode so that we can set up a new job to run tests with ANSI mode on.
Why are the changes needed?
For passing TPCDS plan stability tests under ANSI mode. We are going to set up a new job to run tests with ANSI mode on https://issues.apache.org/jira/browse/SPARK-38154
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually turn on ANSI mode and run tests and check whether all the plan stability tests passed.