[SPARK-38268][SQL] Hide the "failOnError" field in the toString method of Abs/CheckOverflow#35590
Closed
gengliangwang wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-38268][SQL] Hide the "failOnError" field in the toString method of Abs/CheckOverflow#35590gengliangwang wants to merge 3 commits intoapache:masterfrom
gengliangwang wants to merge 3 commits intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
Feb 21, 2022
cloud-fan
approved these changes
Feb 21, 2022
Member
Author
|
Merging to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Hide the "failOnError" field in the toString method of Abs/CheckOverflow. Here are two examples:
abs(-1, true)=>abs(-1)CheckOverflow(0.12, DecimalType(5, 3), true)=>CheckOverflow(0.12, DecimalType(5, 3))Why are the changes needed?
After changes, over 200 test failures of *PlanStabilitySuite are fixed with ANSI mode on. This is important for setting up testing job for ANSI mode.
Also, having the "failOnError" field in the string output of Abs, e.g.
abs(-1, true), is quite odd.Does this PR introduce any user-facing change?
Yes but quite minor, hiding the "failOnError" field in the toString method of Abs/CheckOverflow
How was this patch tested?
Manual turn on ANSI mode and test all the *PlanStabilitySuite