[SPARK-38261][INFRA] Add missing R packages from base image#35583
Closed
khalidmammadov wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-38261][INFRA] Add missing R packages from base image#35583khalidmammadov wants to merge 1 commit intoapache:masterfrom
khalidmammadov wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Related: #35516 |
|
Can one of the admins verify this patch? |
HyukjinKwon
approved these changes
Feb 21, 2022
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Okay, I guess we should better list them all.
Member
|
Merged to master. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 4, 2023
Current GitHub workflow job **Linters, licenses, dependencies and documentation generation** is missing R packages to complete Documentation and API build. **Build and test** - is not failing as these packages are installed on the base image. We need to keep them in-sync IMO with the base image for easy switch back to ubuntu runner when ready. Reference: [**The base image**](https://hub.docker.com/layers/dongjoon/apache-spark-github-action-image/20220207/images/sha256-af09d172ff8e2cbd71df9a1bc5384a47578c4a4cc293786c539333cafaf4a7ce?context=explore) Adding missing packages to the workflow file To make them inline with the base image config and make the job task **complete** for standalone execution (i.e. without this image) No GitHub builds and in the local Docker containers Closes #35583 from khalidmammadov/sync_doc_build_with_base. Authored-by: khalidmammadov <xmamedov@hotmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 8985427) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
This is backported to branch-3.2. |
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Jun 2, 2023
Current GitHub workflow job **Linters, licenses, dependencies and documentation generation** is missing R packages to complete Documentation and API build. **Build and test** - is not failing as these packages are installed on the base image. We need to keep them in-sync IMO with the base image for easy switch back to ubuntu runner when ready. Reference: [**The base image**](https://hub.docker.com/layers/dongjoon/apache-spark-github-action-image/20220207/images/sha256-af09d172ff8e2cbd71df9a1bc5384a47578c4a4cc293786c539333cafaf4a7ce?context=explore) Adding missing packages to the workflow file To make them inline with the base image config and make the job task **complete** for standalone execution (i.e. without this image) No GitHub builds and in the local Docker containers Closes apache#35583 from khalidmammadov/sync_doc_build_with_base. Authored-by: khalidmammadov <xmamedov@hotmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 8985427) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current GitHub workflow job Linters, licenses, dependencies and documentation generation is missing R packages to complete Documentation and API build.
Build and test - is not failing as these packages are installed on the base image.
We need to keep them in-sync IMO with the base image for easy switch back to ubuntu runner when ready.
Reference: The base image
What changes were proposed in this pull request?
Adding missing packages to the workflow file
Why are the changes needed?
To make them inline with the base image config and make the job task complete for standalone execution (i.e. without this image)
Does this PR introduce any user-facing change?
No
How was this patch tested?
GitHub builds and in the local Docker containers