Skip to content

[MINOR][DOCS] fix default value of history server#35577

Closed
itayB wants to merge 1 commit intoapache:masterfrom
itayB:doc
Closed

[MINOR][DOCS] fix default value of history server#35577
itayB wants to merge 1 commit intoapache:masterfrom
itayB:doc

Conversation

@itayB
Copy link
Contributor

@itayB itayB commented Feb 19, 2022

What changes were proposed in this pull request?

Alignment between the documentation and the code.

Why are the changes needed?

The actual default value for spark.history.custom.executor.log.url.applyIncompleteApplication is true and not false as stated in the documentation.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

N/A

@github-actions github-actions bot added the DOCS label Feb 19, 2022
@itayB itayB marked this pull request as ready for review February 19, 2022 18:24
@wangyum wangyum closed this in ae67add Feb 20, 2022
wangyum pushed a commit that referenced this pull request Feb 20, 2022
### What changes were proposed in this pull request?
Alignment between the documentation and the code.

### Why are the changes needed?

The [actual default value ](https://github.com/apache/spark/blame/master/core/src/main/scala/org/apache/spark/internal/config/History.scala#L198) for `spark.history.custom.executor.log.url.applyIncompleteApplication` is `true` and not `false` as stated in the documentation.

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

Closes #35577 from itayB/doc.

Authored-by: Itay Bittan <itay.bittan@gmail.com>
Signed-off-by: Yuming Wang <yumwang@ebay.com>
(cherry picked from commit ae67add)
Signed-off-by: Yuming Wang <yumwang@ebay.com>
wangyum pushed a commit that referenced this pull request Feb 20, 2022
### What changes were proposed in this pull request?
Alignment between the documentation and the code.

### Why are the changes needed?

The [actual default value ](https://github.com/apache/spark/blame/master/core/src/main/scala/org/apache/spark/internal/config/History.scala#L198) for `spark.history.custom.executor.log.url.applyIncompleteApplication` is `true` and not `false` as stated in the documentation.

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

Closes #35577 from itayB/doc.

Authored-by: Itay Bittan <itay.bittan@gmail.com>
Signed-off-by: Yuming Wang <yumwang@ebay.com>
(cherry picked from commit ae67add)
Signed-off-by: Yuming Wang <yumwang@ebay.com>
wangyum pushed a commit that referenced this pull request Feb 20, 2022
### What changes were proposed in this pull request?
Alignment between the documentation and the code.

### Why are the changes needed?

The [actual default value ](https://github.com/apache/spark/blame/master/core/src/main/scala/org/apache/spark/internal/config/History.scala#L198) for `spark.history.custom.executor.log.url.applyIncompleteApplication` is `true` and not `false` as stated in the documentation.

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

Closes #35577 from itayB/doc.

Authored-by: Itay Bittan <itay.bittan@gmail.com>
Signed-off-by: Yuming Wang <yumwang@ebay.com>
(cherry picked from commit ae67add)
Signed-off-by: Yuming Wang <yumwang@ebay.com>
@wangyum
Copy link
Member

wangyum commented Feb 20, 2022

Merged to master, branch-3.2, branch-3.1 and branch-3.0.

kazuyukitanimura pushed a commit to kazuyukitanimura/spark that referenced this pull request Aug 10, 2022
### What changes were proposed in this pull request?
Alignment between the documentation and the code.

### Why are the changes needed?

The [actual default value ](https://github.com/apache/spark/blame/master/core/src/main/scala/org/apache/spark/internal/config/History.scala#L198) for `spark.history.custom.executor.log.url.applyIncompleteApplication` is `true` and not `false` as stated in the documentation.

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

Closes apache#35577 from itayB/doc.

Authored-by: Itay Bittan <itay.bittan@gmail.com>
Signed-off-by: Yuming Wang <yumwang@ebay.com>
(cherry picked from commit ae67add)
Signed-off-by: Yuming Wang <yumwang@ebay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants