[SPARK-38266][SQL] GetDateFieldOperations should skip unresolved nodes#35568
Closed
Ngone51 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-38266][SQL] GetDateFieldOperations should skip unresolved nodes#35568Ngone51 wants to merge 1 commit intoapache:masterfrom
Ngone51 wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
gengliangwang
approved these changes
Feb 18, 2022
cloud-fan
approved these changes
Feb 18, 2022
Contributor
|
thanks, merging to master/3.2! |
cloud-fan
pushed a commit
that referenced
this pull request
Feb 18, 2022
…solved nodes ### What changes were proposed in this pull request? Skip nodes whose children have not been resolved yet within `GetDateFieldOperations`. ### Why are the changes needed? The current `GetDateFieldOperations` could result in `org.apache.spark.sql.catalyst.analysis.UnresolvedException: Invalid call to dataType on unresolved object` in some cases. See the example added in unit test. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added a unit test. Closes #35568 from Ngone51/SPARK-35937-followup. Authored-by: yi.wu <yi.wu@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 15532c7) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Contributor
|
@Ngone51 can you create a new JIRA ticket? SPARK-35937 is in 3.2 |
Member
Author
|
Created the new ticket: https://issues.apache.org/jira/browse/SPARK-38266 |
Ngone51
changed the title
Ngone51
changed the title
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
…solved nodes ### What changes were proposed in this pull request? Skip nodes whose children have not been resolved yet within `GetDateFieldOperations`. ### Why are the changes needed? The current `GetDateFieldOperations` could result in `org.apache.spark.sql.catalyst.analysis.UnresolvedException: Invalid call to dataType on unresolved object` in some cases. See the example added in unit test. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added a unit test. Closes apache#35568 from Ngone51/SPARK-35937-followup. Authored-by: yi.wu <yi.wu@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 15532c7) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Skip nodes whose children have not been resolved yet within
GetDateFieldOperations.Why are the changes needed?
The current
GetDateFieldOperationscould result inorg.apache.spark.sql.catalyst.analysis.UnresolvedException: Invalid call to dataType on unresolved objectin some cases. See the example added in unit test.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added a unit test.