[SPARK-38227][SQL][SS] Apply strict nullability of nested column in time window / session window#35543
Closed
HeartSaVioR wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-38227][SQL][SS] Apply strict nullability of nested column in time window / session window#35543HeartSaVioR wants to merge 3 commits intoapache:masterfrom
HeartSaVioR wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
Author
Contributor
Author
|
It would be ideal if we have a great idea to technically prevent such case (code level, or at least runtime level like fast-fail the query) instead of adding tests to guard against. I don't know whether it is technically feasible or not, just thinking ideally. |
sigmod
approved these changes
Feb 17, 2022
…ime window / session window
HeartSaVioR
force-pushed
the
SPARK-38227
branch
from
8669390 to
5fe04f4
Compare
Contributor
Author
|
cc. @cloud-fan @sigmod @viirya @xuanyuanking Friendly reminder. |
cloud-fan
approved these changes
Feb 21, 2022
viirya
approved these changes
Feb 21, 2022
Member
|
Thanks. Merging to master. |
Contributor
Author
|
Thanks all for reviewing and merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to apply strict nullability of nested column in window struct for both time window and session window, which respects the dataType of TimeWindow and SessionWindow.
Why are the changes needed?
The implementation of rule TimeWindowing and SessionWindowing have been exposed the possible risks of inconsistency between the dataType of TimeWindow/SessionWindow and the replacement. For the replacement, it is possible that analyzer/optimizer may decide the value expressions to be non-nullable.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New tests added.