Skip to content

[SPARK-38105][SQL] Use error classes in the parsing errors of joins #35405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ivoson wants to merge 2 commits into from
Closed

[SPARK-38105][SQL] Use error classes in the parsing errors of joins #35405

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
147e586
migrate join parsing errors to the new error framework
ivoson Feb 6, 2022
b1e5e7e
address comments
ivoson Feb 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,14 @@ object QueryParsingErrors {
}

def joinCriteriaUnimplementedError(join: JoinCriteriaContext, ctx: RelationContext): Throwable = {
new ParseException(s"Unimplemented joinCriteria: $join", ctx)
new ParseException(
errorClass = "INTERNAL_ERROR",
messageParameters = Array(s"Internal error: Unimplemented joinCriteria, $join"),
ctx)
}

def naturalCrossJoinUnsupportedError(ctx: RelationContext): Throwable = {
new ParseException("NATURAL CROSS JOIN is not supported", ctx)
new ParseException("UNSUPPORTED_FEATURE", Array("NATURAL CROSS JOIN."), ctx)
}

def emptyInputForTableSampleError(ctx: ParserRuleContext): Throwable = {
Expand Down
8 changes: 8 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/errors/QueryParsingErrorsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,12 @@ class QueryParsingErrorsSuite extends QueryTest with SharedSparkSession {
message = "Invalid SQL syntax: LATERAL can only be used with subquery.")
}
}

test("UNSUPPORTED_FEATURE: NATURAL CROSS JOIN is not supported") {
validateParsingError(
sqlText = "SELECT * FROM a NATURAL CROSS JOIN b",
errorClass = "UNSUPPORTED_FEATURE",
sqlState = "0A000",
message = "The feature is not supported: NATURAL CROSS JOIN.")
}
}