[SPARK-37896][SQL][FOLLOWUP] Fix NPE in ConstantColumnVector.close() #35324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c21
commented
Jan 25, 2022
|
|
||
| @Override | ||
| public void close() { | ||
| stringData = null; |
Contributor
Author
There was a problem hiding this comment.
This change is not related to the NPE fix, but it's good to have. We should release the memory for UTF8String as well.
Contributor
Author
|
cc @cloud-fan and @Yaohua628 |
Contributor
|
thanks for the fix! |
cloud-fan
approved these changes
Jan 26, 2022
Contributor
|
thanks, merging to master! |
Contributor
Author
|
Thank you @cloud-fan and @Yaohua628 for review! |
senthh
pushed a commit
to senthh/spark-1
that referenced
this pull request
Feb 3, 2022
### What changes were proposed in this pull request? This PR is a followup of apache#35068 to fix the null pointer exception when calling `ConstantColumnVector.close()`. `ConstantColumnVector.childData` can be null for e.g. non-struct data type. ### Why are the changes needed? Fix the exception when cleaning up column vector. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Modified unit test in `ConstantColumnVectorSuite.scala` to exercise the code path of `ConstantColumnVector.close()` for every tested data type. Without the fix, the unit test throws NPE. Closes apache#35324 from c21/constant-fix. Authored-by: Cheng Su <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #35068 to fix the null pointer exception when calling
ConstantColumnVector.close().ConstantColumnVector.childDatacan be null for e.g. non-struct data type.Why are the changes needed?
Fix the exception when cleaning up column vector.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Modified unit test in
ConstantColumnVectorSuite.scalato exercise the code path ofConstantColumnVector.close()for every tested data type. Without the fix, the unit test throws NPE.