[SPARK-37950][SQL] Take EXTERNAL as a reserved table property #35268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Jan 21, 2022
docs/sql-migration-guide.md
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| - Since Spark 3.3, the property `external` become reserved for table; commands fail if you specify `external` property in places like `CREATE TABLE ... TBLPROPERTIES` and `ALTER TABLE ... SET TBLPROPERTIES`. You can set `spark.sql.legacy.notReserveProperties` to `true` to ignore the `ParseException`, in this case, `external` will be silently removed. | |
| - Since Spark 3.3, the table property `external` becomes reserved. Certain commands will fail if you specify the `external` property, such as `CREATE TABLE ... TBLPROPERTIES` and `ALTER TABLE ... SET TBLPROPERTIES`. In Spark 3.2 and earlier, the table property `external` is silently ignored. You can set `spark.sql.legacy.notReserveProperties` to `true` to restore the old behavior. |
cloud-fan
reviewed
Jan 21, 2022
Contributor
There was a problem hiding this comment.
Suggested change
| PROP_EXTERNAL, ctx, "it will be set according the location") | |
| PROP_EXTERNAL, ctx, "please use CREATE EXTERNAL TABLE") |
cloud-fan
reviewed
Jan 21, 2022
Contributor
There was a problem hiding this comment.
I think 'External'='bar' still works?
Contributor
Author
There was a problem hiding this comment.
yeah. 'External'='bar' still works. EXTERNAL is the key word of the hive metastore.
Contributor
There was a problem hiding this comment.
then let's use External and keep this test.
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Take
externalas a reserved table property. and do not allow useexternalfor end-user whenspark.sql.legacy.notReserveProperties==false.Why are the changes needed?
#disscuss.
keep it consistent with other properties like
locationownerproviderand so on.Does this PR introduce any user-facing change?
Yes. end-user could not use
externalas property key when create table with tblproperties and alter table set tblproperties.How was this patch tested?
existed testcase.