Skip to content

[SPARK-37290][SQL] - Exponential planning time in case of non-deterministic function #35233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stelyus wants to merge 4 commits into from
Closed

[SPARK-37290][SQL] - Exponential planning time in case of non-deterministic function #35233

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53ed33d
[SPARK-37290][SQL] Exponential planning time in case of non-determini…
stelyus Jan 17, 2022
ab0684e
[SPARK-37290][SQL] Exponential planning time in case of non-determini…
stelyus Jan 17, 2022
ec3a282
[SPARK-37290][SQL] Exponential planning time in case of non-determini…
stelyus Jan 17, 2022
bc452a7
[SPARK-37290][SQL] Exponential planning time in case of non-determini…
stelyus Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ trait UnaryNode extends LogicalPlan with UnaryLike[LogicalPlan] {
allConstraints += EqualNullSafe(a.toAttribute, l)
case a @ Alias(e, _) =>
Copy link
Contributor

@cloud-fan cloud-fan Feb 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it be sufficient to add if e.deterministic here?

Copy link
Contributor Author

@stelyus stelyus Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updated the PR

// For every alias in `projectList`, replace the reference in constraints by its attribute.
allConstraints ++= allConstraints.map(_ transform {
allConstraints ++= allConstraints.filter(_.deterministic).map(_ transform {
Copy link
Contributor

@cloud-fan cloud-fan Feb 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know how the allConstraints include nondeterministic expressions at the first place? It starts with child.constraints, and looking at the implementation, it should only produce deterministic expressions
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala#L38

Copy link
Contributor Author

@stelyus stelyus Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because of this line:
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala#L192

The alias expression can be non deterministic

case expr: Expression if expr.semanticEquals(e) =>
a.toAttribute
})
Expand Down