[SPARK-37908][K8S][TESTS] Refactoring on pod label test in BasicDriver/ExecutorFeatureStepSuite #35209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itholic
reviewed
Jan 17, 2022
Contributor
itholic
left a comment
itholic
left a comment
There was a problem hiding this comment.
Would you mind refine "Why are the changes needed?" in the PR description a little bit more detail rather than only mentioning the previous discussion ?
It took some time to understand why this changes needed for me.
Otherwise, fix itself looks fine to me :-)
Member
Author
|
@itholic Thanks, udpated. |
Yikun
changed the title
Member
Author
|
cc @dongjoon-hyun This is a followup test reafactor of #34646 as your suggestion. |
dongjoon-hyun
approved these changes
Feb 2, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @Yikun . Sorry for the delay.
Merged to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
There are two type Pod label in current implementations: preset label set by spark and custom label set by user, but there are some mix up in testcase, so this PR just fix it.
Also see realted: #34646 (comment)
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT